Messages in this thread | | | From | "Jason Dravet" <> | Subject | Re: RFC: add udev support to parport_pc | Date | Sat, 31 Dec 2005 12:14:38 -0600 |
| |
>From: Jiri Slaby <slaby@liberouter.org> >To: Jason Dravet <dravet@hotmail.com> >CC: linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org >Subject: Re: RFC: add udev support to parport_pc >Date: Sat, 31 Dec 2005 18:59:15 +0100 > >Jason Dravet napsal(a): > > Here is a patch to parport_pc.c that adds udev support. Without it > > sysfs does not have enough information to give to udev so the lp and > > parport nodes can be created. The only problem I have is the > > kernel_oops when I do the following: insmod parport, insmod parport_pc, > > rmmod parport_pc, rmmod parport, insmod parport, insmod parport_pc, > > rmmod parport_pc, kernel oops. >[snip] > > + if (p->base == 888) /* 888 is dec for 378h */ > > + { > > + class_device_create(parallel_class, NULL, MKDEV(6, 0), NULL, > > "lp0"); > > + class_device_create(parallel_class, NULL, MKDEV(99, 0), NULL, > > "parport0"); > > + } >use please >if () { >} >instead of >if () >{ >} >like the surrounding code > >thanks, >-- >Jiri Slaby www.fi.muni.cz/~xslaby
Will do. Thanks, Jason
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |