Messages in this thread | | | From | (David Wagner) | Subject | Re: [PATCH] Fix user data corrupted by old value return of sysctl | Date | Fri, 30 Dec 2005 22:31:41 +0000 (UTC) |
| |
Yi Yang wrote: >If the user reads a sysctl entry which is of string type > by sysctl syscall, this call probably corrupts the user data > right after the old value buffer, the issue lies in sysctl_string > seting 0 to oldval[len], len is the available buffer size > specified by the user, obviously, this will write to the first > byte of the user memory place immediate after the old value buffer >, the correct way is that sysctl_string doesn't set 0, the user >should do it by self in the program.
That's not just data corruption -- it's also a buffer overrun. Granted, it's "only" a one-byte overrun, but I have seen one-byte overruns be exploitable occasionally in the past. So this sounds to me like a potential security issue, too. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |