lkml.org 
[lkml]   [2005]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][fat] use mpage_readpage when cluster size is page-alignment
From
Date
cai <junjiec@gmail.com> writes:

>>Can't we use mpage_readpage() always? IIRC, that should work fine
>>without disadvantage.
>>
> it should work, but maybe some performance loses if the
> cluster size is not page-alignment, for example, 4 sector/cluster
> in a 4KB/page system.
> because it will fall back to the block_read_full_page when
> non-adjacent block found in do_mpage_readpage, i think.
> the same applies to mpage_readpages too.

Ah, yes.

But if cluster is not fragmented it shouldn't fall back, and rather it
will get advantage. And I guess, even if it fall back to
block_read_full_page(), it would be very trivial.

What do you think? We may need benchmark...
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-29 10:21    [W:5.979 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site