lkml.org 
[lkml]   [2005]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2/3] mutex subsystem: fastpath inlining
On Wed, 28 Dec 2005, Ingo Molnar wrote:

> * Nicolas Pitre <nico@cam.org> wrote:
>
> > > * Nicolas Pitre <nico@cam.org> wrote:
> > >
> > > > Some architectures, notably ARM for instance, might benefit from
> > > > inlining the mutex fast paths. [...]
> > >
> > > what is the effect on text size? Could you post the before- and
> > > after-patch vmlinux 'size kernel/test.o' output in the nondebug case,
> > > with Arjan's latest 'convert a couple of semaphore users to mutexes'
> > > patch applied? [make sure you've got enough of those users compiled in,
> > > so that the inlining cost is truly measured. Perhaps also do
> > > before/after 'size' output of a few affected .o files, without mixing
> > > kernel/mutex.o into it, like vmlinux does.]
> >
> > Theory should be convincing enough. [...]
>
> please provide actual measurements (just a simple pre-patch and
> post-patch 'size' output of vmlinux is enough), so that we can see the
> inlining cost.

This is with all mutex patches applied and CONFIG_DEBUG_MUTEX_FULL=n,
therefore using the current semaphore code:

text data bss dec hex filename
1821108 287792 88264 2197164 2186ac vmlinux

Now with CONFIG_DEBUG_MUTEX_FULL=y to substitute semaphores with
mutexes:

text data bss dec hex filename
1797108 287568 88172 2172848 2127b0 vmlinux

Finally with CONFIG_DEBUG_MUTEX_FULL=y and fast paths inlined:

text data bss dec hex filename
1807824 287136 88172 2183132 214fdc vmlinux

This last case is not the smallest, but it is the fastest.

> Note that x86 went to a non-inlined fastpath _despite_
> having a compact CISC semaphore fastpath.

The function call overhead on x86 is less significant than the ARM one,
so always calling out of line code might be sensible in that case.


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-29 03:56    [W:0.067 / U:0.156 seconds]
©2003-2011 Jasper Spaans. Advertise on this site