Messages in this thread | | | Date | Wed, 28 Dec 2005 19:30:25 -0500 | From | Sonny Rao <> | Subject | Re: cpu hotplug oops on 2.6.15-rc5 |
| |
On Wed, Dec 28, 2005 at 01:30:12PM -0600, Nathan Lynch wrote: > I wonder if this is related to the problem Sonny is seeing -- powerpc's > definitions of cpu_to_node et al. are not being used. The culprit is > some too-clever preprocessor usage in asm-generic/topology.h, for > example: > > > #ifndef cpu_to_node > #define cpu_to_node(cpu) (0) > #endif > > But asm-powerpc/topology.h has cpu_to_node defined as a static inline > (which does not make it a preprocessor symbol), so we get the generic > - and incorrect - definition. > > Does removing the #include of asm-generic/topology.h from the bottom > of asm-powerpc/topology.h have any effect?
Hi, no it doesn't make a difference. That include is protected by CONFIG_NUMA as well, so it never gets hit. At Anton's suggestion I even put in an #error into asm-generic/topology.h to make sure it wasn't an issue -- it didn't hit.
Sonny - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |