lkml.org 
[lkml]   [2005]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 01/2] allow gcc4 to control inlining
From
Date
On Wed, 2005-12-28 at 18:39 +0000, Al Viro wrote:
> On Wed, Dec 28, 2005 at 12:46:53PM +0100, Ingo Molnar wrote:
> > allow gcc4 compilers to decide what to inline and what not - instead
> > of the kernel forcing gcc to inline all the time.
>
> > +#define noinline __attribute__((noinline))
> > +#define __always_inline inline __attribute__((always_inline))
> > #define __must_check __attribute__((warn_unused_result))
> > #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
>
> You seem to be missing the rest of the patch - namely, addition of
> always_inline where it is needed now...
>
> Note that we *do* need it in quite a few places. Anything that relies on
> dead code elimination to kill a call of function that doesn't exist
> would better be always inlined...

on x86-64 that seems to only be fix_to_virt though.. so it's really not
that many.

(based on making "inline" a define for noinline and then an
allyesconfig)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-28 20:55    [W:0.041 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site