Messages in this thread | | | Date | Tue, 27 Dec 2005 23:05:33 +0100 | From | Pavel Machek <> | Subject | Re: [linux-pm] [patch] pm: fix runtime powermanagement's /sys interface |
| |
Hi!
> > static ssize_t state_show(struct device * dev, struct device_attribute *attr, char * buf) > > { > > - return sprintf(buf, "%u\n", dev->power.power_state.event); > > + if (dev->power.power_state.event) > > + return sprintf(buf, "suspend\n"); > > + else > > + return sprintf(buf, "on\n"); > > } > > Are you sure that having only 2 options (suspend/on) is enough at the > core level? I could envision having more levels, like "poweroff", etc?
Note that interface is 0/2, currently, so this is improvement :-).
One day, when we find device that needs it, we may want to add more states. I don't know about such device currently.
Pavel -- Thanks, Sharp! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |