Messages in this thread Patch in this message | | | Date | Mon, 26 Dec 2005 23:33:42 +0100 (MET) | From | Jan Engelhardt <> | Subject | Re: recommended mail clients [was] [PATCH] ati-agp suspend/resume support (try 2) |
| |
>Maybe this is a stupid question but in terms of inline patches what exactly >would be ideal behavior from a mail client for LKML patch submitters? What >line lengths are expected to be maintained, preferred encodings, tabs vs. >spaces, etc? I have noticed that some patch submitters append an EOF after >the patch, while others do not.
That's because not provind #eof could potentially bring problems (not with the clever poster, though), e.g. in:
--- a/lalala +++ b/lalala @@ -123,456 +789,1012 @@ contextline1 contextline2 contextline3 -remove +added
My name dash dash space my signature
There are actually two problems in there. The first is that some empty context lines are missing, the second is that they have to have a leading space, too. The #eof I am adding is basically so that you see when a patch is really ending, because there is also diff's -c option which you can tune the number of potentially empty lines.
Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |