lkml.org 
[lkml]   [2005]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 05/15] Generic Mutex Subsystem, mutex-core.patch

* Oleg Nesterov <oleg@tv-sign.ru> wrote:

> But why we can't add the waiter to ->wait_list _after_ xchg() ? What
> makes the difference? Fastpath atomic op can happen before or after
> xchg(), this is ok. Unlock path will look at ->wait_list only after
> taking spinlock, at this time we already added this waiter to the
> ->wait_list.
>
> In other words: we are holding ->wait_lock, nobody can even look at
> ->wait_list. We can add the waiter to ->wait_list before or after
> atomic_xchg() - it does not matter.

hm, you are right - i've added this optimization.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-21 19:29    [W:0.024 / U:0.912 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site