Messages in this thread | | | Date | Tue, 20 Dec 2005 17:50:12 -0800 | From | Mitchell Blank Jr <> | Subject | Re: [RFC][PATCH 1/6] RTC subsystem, class |
| |
Alessandro Zummo wrote: > > > +static const unsigned char rtc_days_in_month[] = { > > > + 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 > > > +}; > > > +EXPORT_SYMBOL(rtc_days_in_month); > > > > exporting static symbols is pretty wrong. Exporting tables is pretty > > bad style aswell. > > Tables like this one are often used in rtc drivers. What > can I use instead?
Why not just provide a macro in a .h file? Something like:
/* Days in month -- month is in the range (0..11), no leap year */ #define rtc_days_in_month(mon) (28 + ((0xEEFBB3 >> ((mon) * 2)) & 3))
-Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |