[lkml]   [2005]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [spi-devel-general] Re: [PATCH/RFC] SPI: async message handing library update
On Monday 19 December 2005 7:40 am, dmitry pervushin wrote:
> On Sun, 2005-12-18 at 10:59 -0800, David Brownell wrote:
> > chipselect = !t->cs_change;
> > if (chipselect);
> > continue;
> >
> > bitbang->chipselect(spi, 0);
> >
> > /* REVISIT do we want the udelay here instead?
> > */
> > msleep(1);
> Ohhh. Have you intentionally put the semicolon after "if
> (chipselect)" ?

Nope. Good catch ... haven't had a chance to try that yet with that driver;
not all drivers actually need to drop chipselect like that.

Any other comments about that approach to the "let someone else manage the
queue"? This one's more clearly "implementation utilities" than what you had
seemed to be talking about before, but I think it does address a point where
I think we were agreeing: it should be easy for people to whip together a
controller driver by providing just some lower level I/O calls.

- Dave

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-12-20 08:27    [W:0.071 / U:6.872 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site