lkml.org 
[lkml]   [2005]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 09/15] Generic Mutex Subsystem, mutex-migration-helper-x86_64.patch

    * Andi Kleen <ak@suse.de> wrote:

    > On Mon, Dec 19, 2005 at 02:38:27AM +0100, Ingo Molnar wrote:
    > >
    > > introduce the arch_semaphore type on x86_64, to ease migration to
    > > mutexes.
    >
    > As a small feedback I don't think the name arch_semaphore is very good
    > because it means nothing. How about counting_semaphore which is what
    > it actually is?

    yeah, this is one of the open issues, and i have no strong preference
    for any of the naming variants. I considered two things when i went for
    the 'arch_semaphore' name:

    1) the name should be temporary, and we could make it 'struct semaphore'
    once the transition phase is over. Linus is totally correct
    suggesting that there's nothing wrong about the 'struct semaphore'
    name. It just happens to clash with my intended type-based
    categorization of 'known counting semaphores' from 'unknown
    semaphores'.

    2) i wanted to signal that this is the per-arch semaphore
    implementation.

    another candidate name was 'struct __semaphore'. I like 'struct
    counting_semaphore' too, but maybe it's a bit too long as a name?
    Anyway, i'm very much open to suggestions how to name it best.

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-19 17:40    [W:4.477 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site