Messages in this thread | | | Subject | Re: [openib-general] Re: [PATCH 13/13] [RFC] ipath Kconfig and Makefile | From | Robert Walsh <> | Date | Mon, 19 Dec 2005 16:32:55 -0800 |
| |
> > @@ -0,0 +1,15 @@ > > +EXTRA_CFLAGS += -Idrivers/infiniband/include > If this is needed then some header files should be moved to include/rdma
Actually, this is done by other IB drivers, too, so I assumed it was OK. Roland, have you any comments on this?
> > + > > +ipath_core-objs := ipath_copy.o ipath_driver.o \ > > + ipath_dwordcpy.o ipath_ht400.o ipath_i2c.o ipath_layer.o \ > > + ipath_lib.o ipath_mlock.o > > + > > +ib_ipath-objs := ipath_mad.o ipath_verbs.o > > Please use: > ipath_core-y := ... > ib_ipath-y := ... > > Use of -y let you do better Kconfig selection in the makefile, and is > preferred compared to -objs
No problem.
Regards, Robert.
-- Robert Walsh Email: rjwalsh@pathscale.com PathScale, Inc. Phone: +1 650 934 8117 2071 Stierlin Court, Suite 200 Fax: +1 650 428 1969 Mountain View, CA 94043 [unhandled content-type:application/pgp-signature] | |