Messages in this thread | | | From | Neil Brown <> | Date | Mon, 19 Dec 2005 11:45:24 +1100 | Subject | Re: [2.6 patch] i386: always use 4k stacks |
| |
On Friday December 16, bunk@stusta.de wrote: > > The nfsd code uses inline in too many places.
Does it? Most of the uses are either - truly tiny bits of code - code that is used only once which, as you as, will not currently be auto-inlined on i386, so we do it by hand.
An exception is some of the xdr code. If I #define inline in nfs3xdr.c, the nfsd.o changes from text data bss dec hex filename 76132 3464 2408 82004 14054 ../mm-i386/fs/nfsd/nfsd.o to text data bss dec hex filename 72452 3464 2408 78324 131f4 ../mm-i386/fs/nfsd/nfsd.o which is probably a win.
Is that what you were referring to?
> > If this struct is really a problem (which I doubt considering it's > size), I'd prefer it being kmalloc'ed.
It's hard to *know* if it is a problem, but I am conscious that nfsd adds measurably to stack depth for filesystem paths, and probably isn't measured nearly as often. It's true that 50 bytes out of 4K isn't a lot, but wastage that can be avoided, should be avoided.
NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |