lkml.org 
[lkml]   [2005]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/13] [RFC] ipath basic headers
    From
    Date
    > Do we really need this ugly userspace emulation code in the kernel?

    Probably not. I'll look into removing it.

    > What is this used for? Why can't yo use memcpy?

    Our chip can only handle double-word copies.

    > > +#define round_up(v,sz) (((v) + (sz)-1) & ~((sz)-1))
    >
    > Please use ALIGN().

    Fair enough.

    > You seem to be introducing loads of new ioctls. Any reason you can't
    > use sysfs and/or configfs?

    I'll see what people here think of that idea.

    > > +#define ips_get_ipath_ver(ipath_header) (((ipath_header) >> INFINIPATH_I_VERS_SHIFT) \
    > > + & INFINIPATH_I_VERS_MASK)
    >
    > Please use static inlines instead for readability.

    OK.

    Regards,
    Robert.

    --
    Robert Walsh Email: rjwalsh@pathscale.com
    PathScale, Inc. Phone: +1 650 934 8117
    2071 Stierlin Court, Suite 200 Fax: +1 650 428 1969
    Mountain View, CA 94043.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-17 22:58    [W:0.023 / U:35.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site