lkml.org 
[lkml]   [2005]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/13] [RFC] ipath core misc files
    Robert Walsh <rjwalsh@pathscale.com> wrote:
    >
    > > > +int ipath_mlock(unsigned long start_page, size_t num_pages, struct page **p)
    > > OK. It's perhaps not a very well named function.
    >
    > Really? Suggestion for a better name?
    >

    ipath_get_user_pages() would cause the least surprise.

    > > > + }
    > > > + vm->vm_flags |= VM_SHM | VM_LOCKED;
    > > > +
    > > > + return 0;
    > > > +}
    > >
    > > I don't think we want to be setting the user's VMA's vm_flags in this
    > > manner. This is purely to retain the physical page across fork?
    >
    > I didn't write this bit of the driver, but I believe this is the case.
    > Is there a better way of doing this?

    This stuff has been churning a bit lately. I've drawn Hugh Dickins's
    attention to the patch - he'd have a better handle on what the best
    approach would be.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-18 04:12    [W:0.043 / U:0.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site