lkml.org 
[lkml]   [2005]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [openib-general] Re: [PATCH 13/13] [RFC] ipath Kconfig and Makefile
    From
    Date
    > The driver shouldn't use assembler code and therefore no longer depend 
    > on X86_64.

    Agreed about the assembler, but one way or the other, x86_64 is the only
    arch we support.

    > -Wall is always set when compiling the kernel.

    Fine.

    > -O3 doesn't make much sense since the fight for producing the fastest
    > code is between -O2 and -Os.

    Makes many nanoseconds of difference to us for our latency numbers. At
    the low latency numbers we measuring (1.29us), this is a very important
    difference to our customers.

    > You don't want to always compile your driver with -g3.

    Good point. I'll ask around here why we're doing this.

    > > +_ipath_idstr:="$$""Id: kernel.org InfiniPath Release 1.1 $$"" $$""Date: $(shell date +%F-%R)"" $$"
    > > +EXTRA_CFLAGS += -D_IPATH_IDSTR='$(_ipath_idstr)' -DIPATH_KERN_TYPE=0
    > >...
    >
    > Please move the _IPATH_IDSTR revision tag to a header file and remove
    > IPATH_KERN_TYPE.

    I'll see what I can do.

    Regards,
    Robert.

    --
    Robert Walsh Email: rjwalsh@pathscale.com
    PathScale, Inc. Phone: +1 650 934 8117
    2071 Stierlin Court, Suite 200 Fax: +1 650 428 1969
    Mountain View, CA 94043.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-17 23:57    [W:0.020 / U:2.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site