Messages in this thread | | | Subject | Re: [PATCH 2.6 1/2] usb/input: Add relayfs support to appletouch driver | Date | Fri, 16 Dec 2005 14:29:47 -0300 | From | Horst von Brand <> |
| |
Olof Johansson <olof@lixom.net> wrote:
Just saw this.
> On Thu, Dec 15, 2005 at 12:31:08AM +0100, Michael Hanselmann wrote:
> > diff -rup linux-2.6.15-rc5.orig/drivers/usb/input/appletouch.c b/drivers/usb/input/appletouch.c > > --- linux-2.6.15-rc5.orig/drivers/usb/input/appletouch.c 2005-12-13 22:44:24.000000000 +0100 > > +++ b/drivers/usb/input/appletouch.c 2005-12-15 00:25:09.000000000 +0100
[...]
> > +#if defined(CONFIG_RELAYFS_FS) || defined(CONFIG_RELAYFS_FS_MODULE) > > +#include <linux/relayfs_fs.h> > > +#endif
Why can't this be included regardless? If it does something that only makes sense if relayfs is in use, better have that decision inside the header file (least somebody just includes it and...). -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |