lkml.org 
[lkml]   [2005]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 6/6] statistics infrastructure - exploitation: zfcp
> >>	if (device_register(&unit->sysfs_device)) {
> >>+ zfcp_unit_statistic_unregister(unit);
> >> kfree(unit);
> >> return NULL;
> >> }
> >> if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) {
> >>+ zfcp_unit_statistic_unregister(unit);
> >> device_unregister(&unit->sysfs_device);
> >> return NULL;
> >> }
> >Unrelated, but doesn't that error path forget to release unit?
>
> correct, I guess ... Andreas, could you fix this?

The release function frees the unit. Nothing to fix here.

Heiko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-14 18:19    [W:0.032 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site