Messages in this thread | | | Date | Wed, 14 Dec 2005 18:17:14 +0100 | From | Heiko Carstens <> | Subject | Re: [patch 6/6] statistics infrastructure - exploitation: zfcp |
| |
> >> if (device_register(&unit->sysfs_device)) { > >>+ zfcp_unit_statistic_unregister(unit); > >> kfree(unit); > >> return NULL; > >> } > >> if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) { > >>+ zfcp_unit_statistic_unregister(unit); > >> device_unregister(&unit->sysfs_device); > >> return NULL; > >> } > >Unrelated, but doesn't that error path forget to release unit? > > correct, I guess ... Andreas, could you fix this?
The release function frees the unit. Nothing to fix here.
Heiko - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |