Messages in this thread |  | | | Subject | Re: sonypi searching new maintainer (Was: Re: [RFT] Sonypi: convert to the new platform device interface) | | From | Stelian Pop <> | | Date | Wed, 14 Dec 2005 07:46:40 +0100 |
Le mardi 13 décembre 2005 à 17:06 -0500, Dmitry Torokhov a écrit : > On 12/13/05, Stelian Pop <stelian@popies.net> wrote: > > Le mardi 13 décembre 2005 à 15:48 -0500, Dmitry Torokhov a écrit : > > > On 12/13/05, Stelian Pop <stelian@popies.net> wrote: > > > > Le mardi 13 décembre 2005 à 14:04 -0500, Dmitry Torokhov a > > > > > > > sonypi: unknown event port1=0x0f,port2=0x05 > > > > [...] > > > > > > Oh, there seems to be a spurious interrupt happening at modules > > > > > > insertion (I suspect sonypi_enable triggering and ignoring it), but this > > > > > > happens with the old module too and I never noticed it before. Wouldn't > > > > > > make more sense to print the warning even if verbose=0 to be able to > > > > > > catch it timely? I mean it's since 2.4 times I don't enable verbose mode > > > > > > in sonypi... > > > > > > > > > > > Probably, let's see what Stelian will say. > > > > > > > > This is the "ok I'm loaded" event. I am not sure this event is available > > > > on all the sonypi supported platforms, that's why it hasn't been defined > > > > as a known event. And it doesn't make much sense to forward it anyways. > > > > > > > > I would leave it like it is now. > > > > > > > > > > But when it is reported is it the same event? > > > > I don't follow you here... > > > > I was talking about that "ok, i'm loaded" event. When it is reported > is it the same v1,v2 pair all the time?
I have no idea. That's one of the problems with the sonypi events: different laptops behave differently, and sometimes Sony even changes the meaning of some events... > If it is the same we could > suppress "unknown" message in verbose mode.
Why would you want to suppress a message in verbose mode ? The verbose option is there exactly for that: show the user all the data coming from the hardware, and depending on the verbose value only show the data which hasn't been decoded, or all of it.
I don't think that adding a special hack for this event in an already hacky driver has some added value.
Stelian. -- Stelian Pop <stelian@popies.net>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |