Messages in this thread Patch in this message |  | | | Date | Tue, 13 Dec 2005 00:22:29 -0800 | | From | Greg KH <> | | Subject | [patch 06/26] setkeys needs root |
| |
-stable review patch. If anyone has any objections, please let us know.
------------------ From: Daniel Drake <dsd@gentoo.org> This patch combines commit 0b360adbdb54d5b98b78d57ba0916bc4b8871968 (make setkeys root-only) and commit e3f17f0f6e98f58edb13cb38810d93e6d4808e68 (only disallow setting by users)
Because people can play games reprogramming keys and leaving traps for the next user of the console.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/char/vt_ioctl.c | 6 ++++++ 1 file changed, 6 insertions(+) --- linux-2.6.14.3.orig/drivers/char/vt_ioctl.c +++ linux-2.6.14.3/drivers/char/vt_ioctl.c @@ -80,6 +80,9 @@ do_kdsk_ioctl(int cmd, struct kbentry __ if (copy_from_user(&tmp, user_kbe, sizeof(struct kbentry))) return -EFAULT; + if (!capable(CAP_SYS_TTY_CONFIG)) + perm = 0; + switch (cmd) { case KDGKBENT: key_map = key_maps[s]; @@ -192,6 +195,9 @@ do_kdgkb_ioctl(int cmd, struct kbsentry int i, j, k; int ret; + if (!capable(CAP_SYS_TTY_CONFIG)) + perm = 0; + kbs = kmalloc(sizeof(*kbs), GFP_KERNEL); if (!kbs) { ret = -ENOMEM; -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |