Messages in this thread | | | Date | Wed, 14 Dec 2005 04:51:11 +0100 | From | Andi Kleen <> | Subject | Re: [discuss] [PATCH] Export cpu topology for IA32 and x86_64 by sysfs |
| |
On Wed, Dec 14, 2005 at 11:11:00AM +0800, Zhang, Yanmin wrote: > The patch exports the cpu topology info through sysfs on ia32/x86_64 > machines. The info is similar to /proc/cpuinfo. > > The exported items are: > /sys/devices/system/cpu/cpuX/topology/physical_package_id(representing > the physical package id of cpu X) > /sys/devices/system/cpu/cpuX/topology/core_id (representing the cpu core > id to cpu X) > /sys/devices/system/cpu/cpuX/topology/thread_siblings (representing the > thread siblings to cpu X) > /sys/devices/system/cpu/cpuX/topology/core_siblings (represeting the > core siblings to cpu X)
Hmm, I'm not sure it is that useful. Did someone decide to move all information from cpuinfo into sysfs?
And if it's done I think it needs Documentation somewhere.
Anyways, the notifier is wrong. You need to handle CPU_UP_CANCELLED too.
And you could probably shrink the code size of the show function in half by switching data instead of functions.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |