![]() | |||||||||||||
Messages in this thread
|
Nick Piggin <nickpiggin@yahoo.com.au> wrote: > Any reason why you're setting up your own style of waitqueue in > mutex-simple.c instead of just using the kernel's style of waitqueue? Because I can steal the code from FRV's semaphores or rw-semaphores, and this way I can be sure of what I'm doing. Note that the sleeping processes are generally dequeued and dispatched by the up() function, which means they don't have to take the spinlock themselves. This may be possible to do magically with the waitqueue stuff, but I'm not sure how to do it; it's horribly complicated to read through the sources and there isn't much documentation. > > + mb(); > > This should be smp_mb(), I think. Yes. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-12-13 12:25 [from the cache] ©2003-2008 | |||||||||||||