[lkml]   [2005]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

    * Christoph Hellwig <> wrote:

    > On Tue, Dec 13, 2005 at 08:54:41AM +0100, Ingo Molnar wrote:
    > > - i did not touch the 'struct semaphore' namespace, but introduced a
    > > 'struct compat_semaphore'.
    > Because it's totally braindead. Your compat_semaphore is a real
    > semaphore and your semaphore is a mutex. So name them as such.

    well, i had the choice between a 30K patch, a 300K patch and a 3000K
    patch. I went for the 30K patch ;-)

    > > - i introduced a 'type-sensitive' macro wrapper that switches down()
    > > (and the other APIs) to either to the assembly variant (if the
    > > variable's type is struct compat_semaphore), or switches it to the new
    > > generic mutex (if the type is struct semaphore), at build-time. There
    > > is no runtime overhead due to this build-time-switching.
    > And this one is probably is a great help to win the obsfucated C
    > contests, but otherwise just harmfull.

    i never found it to be harmful in any way, and we've now got a year of
    experience with them. Could you elaborate?

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-12-13 10:43    [W:0.021 / U:4.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site