lkml.org 
[lkml]   [2005]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Cpuset: rcu optimization of page alloc hook
    Paul Jackson a écrit :

    > +
    > +static kmem_cache_t *cpuset_cache;
    > +

    Hi Paul

    Please do use __read_mostly for new kmem_cache :

    static kmem_cache_t *cpuset_cache __read_mostly;

    If not, the pointer can sit in the midle of a highly modified cache line, and
    multiple CPUS will have memory cache misses to access the cpuset_cache, while
    slab code/data layout itself is very NUMA/SMP friendly.

    Eric
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-12 09:53    [W:0.021 / U:65.616 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site