Messages in this thread | | | Date | Mon, 12 Dec 2005 13:26:43 -0700 | From | Matthew Wilcox <> | Subject | Re: [patch 2/4] i386/x86-64: Implement fallback for PCI mmconfig to type1 |
| |
On Mon, Dec 12, 2005 at 12:01:23PM -0800, Greg Kroah-Hartman wrote: > When there is no entry for a bus in MCFG fall back to type1. This is > especially important on K8 systems where always some devices can't be > accessed using mmconfig (in particular the builtin northbridge doesn't > support it for its own devices) [...] > -static int pci_conf1_read(unsigned int seg, unsigned int bus, > +int pci_conf1_read(unsigned int seg, unsigned int bus,
I don't like this at all. We already have a mechanism to use different accessors per-bus (bus->ops->read()); calling the type1 accessors from the mmconfig accessors just seems wrong.
> + if (!base) > + return pci_conf1_read(seg,bus,devfn,reg,len,value);
Should be space after commas.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |