lkml.org 
[lkml]   [2005]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/3] Link lxdialog with mconf directly
    Dear diary, on Mon, Dec 12, 2005 at 08:14:22PM CET, I got a letter
    where Sam Ravnborg <sam@ravnborg.org> said that...
    > On Mon, Dec 12, 2005 at 01:41:59AM +0100, Petr Baudis wrote:
    > > The following series revives one three years old patch, turning lxdialog
    > > to a library and linking it directly to mconf, making menuconfig nicer and
    > > things in general quite simpler and cleaner.
    > >
    > > The first two patches make slight adjustements to kbuild in order to make
    > > liblxdialog possible. The third patch does the libification itself and
    > > appropriate modifications to mconf.c.
    >
    > Why not just copy over relevant files to scripts/kconfig?
    > Then no playing tricks with libaries etc. is needed, and everythings
    > just works.
    >
    > It is only 8 files and prefixing them with lx* would make them
    > stand out compared to the rest. It is not like there is any user planned
    > for the lxdialog functionality in the kernel, and kconfig users outside
    > the kernel I beleive copy lxdialog with rest of kconfig files.

    Ok. I didn't want to pollute scripts/kconfig/ too much, but if it's ok
    by you, I can do it that way. I will submit another series later in the
    evening.

    > Btw. the work you are doing are clashing with a general cleanup effort
    > of lxdialog I have in -mm at the moment.
    > I received only very limited feedback = looks ok.
    > Integrating principles from your old patch was on my TODO list.

    Do you mean the series you posted at Nov 21? Should I just rebase my
    patches on top of that?

    FWIW, the changes there look fine to me. I actually wanted to change the
    indentation of the menus as well; it looks horrible especially in the
    singlemenu mode.

    > I have something in the works that uses linked list instead of a
    > preallocated array, to keep the dynamic behaviour. I will probarly make
    > a version with the linked list approach but otherwise use your changes
    > to mconf.c. But it will take a few days until I get to it.

    I can do it and include it in the updated series.

    --
    Petr "Pasky" Baudis
    Stuff: http://pasky.or.cz/
    VI has two modes: the one in which it beeps and the one in which
    it doesn't.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-12 21:10    [W:0.025 / U:151.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site