lkml.org 
[lkml]   [2005]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/4] Hugetlb: Remove duplicate i_size check
    From
    Date
    Hugetlb: Remove duplicate i_size check

    On Wed, 2005-10-26 at 12:00 +1000, David Gibson wrote:
    > - The check against i_size was duplicated: once in
    > find_lock_huge_page() and again in hugetlb_fault() after taking the
    > page_table_lock. We only really need the locked one, so remove the
    > other.

    Original post by David Gibson <david@gibson.dropbear.id.au>

    Version 2: Wed 9 Nov 2005
    Split this cleanup out into a standalone patch

    Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
    Signed-off-by: Adam Litke <agl@us.ibm.com>
    ---
    hugetlb.c | 7 -------
    1 files changed, 7 deletions(-)
    diff -upN reference/mm/hugetlb.c current/mm/hugetlb.c
    --- reference/mm/hugetlb.c
    +++ current/mm/hugetlb.c
    @@ -344,19 +344,12 @@ static struct page *find_lock_huge_page(
    {
    struct page *page;
    int err;
    - struct inode *inode = mapping->host;
    - unsigned long size;

    retry:
    page = find_lock_page(mapping, idx);
    if (page)
    goto out;

    - /* Check to make sure the mapping hasn't been truncated */
    - size = i_size_read(inode) >> HPAGE_SHIFT;
    - if (idx >= size)
    - goto out;
    -
    if (hugetlb_get_quota(mapping))
    goto out;
    page = alloc_huge_page();
    --
    Adam Litke - (agl at us.ibm.com)
    IBM Linux Technology Center

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-10 00:40    [W:0.023 / U:0.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site