lkml.org 
[lkml]   [2005]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/39] NLKD - early/late CPU up/down notification
    On Wed, Nov 09, 2005 at 06:09:27PM +0100, Jan Beulich wrote:
    > >>> Greg KH <greg@kroah.com> 09.11.05 17:45:44 >>>
    > >#ifdef in the .h file is not needed. Please fix your email client to
    > >send patches properly.
    >
    > It's not needed, sure, but by having it there I just wanted to make
    > clear that this is something that never can be called from a module
    > (after all, why should one find out at modpost time (and maybe even miss
    > the message since there are so many past eventual symbol resolution
    > warnings) when one can already at compile time.

    If it isn't present, and you do a build, you will still get the error at
    build time, just during a different part of it. Adding #ifdef just to
    move the error to a different part of the build isn't needed. Remember,
    we want to not use #ifdef at all if we can ever help it.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-09 18:22    [W:0.019 / U:180.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site