lkml.org 
[lkml]   [2005]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/8] Direct Migration V2: Avoid writeback / page_migrate() method
    On Wed, 9 Nov 2005, Nikita Danilov wrote:

    > > +#ifdef CONFIG_MIGRATION
    > > +extern int buffer_migrate_page(struct page *, struct page *);
    > > +#else
    > > +#define buffer_migrate_page(a,b) NULL
    > > +#endif
    >
    > Depending on the CONFIG_MIGRATION, the type of buffer_migrate_page(a,b)
    > expansion is either int or void *, which doesn't look right.

    But its right. You need to think about buffer_migrate_page as a pointer to
    a function.

    > Moreover below you have initializations
    >
    > .migrate_page = buffer_migrate_page,
    >
    > that wouldn't compile when CONFIG_MIGRATION is not defined (as macro
    > requires two arguments).

    NULL is a void * pointer which should work.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-09 18:10    [W:0.022 / U:31.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site