lkml.org 
[lkml]   [2005]   [Nov]   [8]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
DateTue, 8 Nov 2005 08:36:35 +0100
FromIngo Molnar <>
SubjectRe: [PATCH 16/21] i386 Eliminate duplicate segment macros
* Zachary Amsden <zach@vmware.com> wrote:

> +#define get_desc_32bit(desc)	(((desc)->b >> 22) & 1)
> +#define get_desc_contents(desc)	(((desc)->b >> 10) & 3)
> +#define get_desc_writable(desc)	(((desc)->b >>  9) & 1)
> +#define get_desc_gran(desc)	(((desc)->b >> 23) & 1)
> +#define get_desc_present(desc)	(((desc)->b >> 15) & 1)
> +#define get_desc_usable(desc)	(((desc)->b >> 20) & 1)

naming nit: shouldnt they be 'desc_32bit()/desc_writable()/...'? No need 
for the get_ i think.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-08 07:38    [from the cache]
©2003-2008