Messages in this thread | | | Date | Tue, 8 Nov 2005 08:36:35 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 16/21] i386 Eliminate duplicate segment macros |
| |
* Zachary Amsden <zach@vmware.com> wrote:
> +#define get_desc_32bit(desc) (((desc)->b >> 22) & 1) > +#define get_desc_contents(desc) (((desc)->b >> 10) & 3) > +#define get_desc_writable(desc) (((desc)->b >> 9) & 1) > +#define get_desc_gran(desc) (((desc)->b >> 23) & 1) > +#define get_desc_present(desc) (((desc)->b >> 15) & 1) > +#define get_desc_usable(desc) (((desc)->b >> 20) & 1)
naming nit: shouldnt they be 'desc_32bit()/desc_writable()/...'? No need for the get_ i think.
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |