lkml.org 
[lkml]   [2005]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] [MMC] wbsd pnp suspend
Date
On Tuesday 08 November 2005 01:57, Pierre Ossman wrote:
> Andrew Morton wrote:
> > Pierre Ossman <drzeus@drzeus.cx> wrote:
> >> + if (host->config != 0)
> >> + {
> >> + if (!wbsd_chip_validate(host))
> >> + {
> >
> > Like:
> >
> > if (host->config != 0) {
> > if (!wbsd_chip_validate(host)) {
> >
> > please.
> >
>
> We had this discussion the last patch for this driver. It's horribly
> wrong when it comes to coding style so keeping patches in the same style
> as the rest of the driver is the lesser evil (IMHO).
>

Aside from unusual brace placement it does not look too bad. How about
running it through Lindent to fix it once and for all?

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-08 08:08    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site