Messages in this thread | | | Date | Tue, 08 Nov 2005 11:08:30 -0800 | From | Matthew Dobson <> | Subject | Re: [PATCH 8/8] Inline 3 functions |
| |
Pekka J Enberg wrote: > On Mon, 7 Nov 2005, Matthew Dobson wrote: > >>I found three functions in slab.c that have only 1 caller (kmem_getpages, >>alloc_slabmgmt, and set_slab_attr), so let's inline them. > > > Why? They aren't on the hot path and I don't see how this is an > improvement... > > Pekka
Well, no, they aren't on the hot path. I just figured since they are only ever called from one other function, why not inline them? If the sentiment is that it's a BAD idea, I'll drop it.
-Matt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |