lkml.org 
[lkml]   [2005]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: 2.6.14-mm1
Andrew Morton wrote:
>Changes since 2.6.14-rc5-mm1:
>
[...]
> git-audit.patch
There are many errors produced by this patch. I don't have any security model
enabled and in audit_ipc_context security_ipc_getsecurity returns -EOPNOTSUPP,
that causes audit_panic("error in audit_ipc_context");

>char *audit_ipc_context(struct kern_ipc_perm *ipcp)
>{
> struct audit_context *context = current->audit_context;
> char *ctx = NULL;
> int len = 0;
>
> if (likely(!context))
> return NULL;
>
> len = security_ipc_getsecurity(ipcp, NULL, 0);
This fails here with -EOPNOTSUPP, and it goes to the error_path label.

> if (len < 0)
> goto error_path;
>
> ctx = kmalloc(len, GFP_ATOMIC);
> if (!ctx)
> goto error_path;
>
> len = security_ipc_getsecurity(ipcp, ctx, len);
> if (len < 0)
> goto error_path;
>
> return ctx;
>
>error_path:
> if (ctx)
> kfree(ctx);
> audit_panic("error in audit_ipc_context");
> return NULL;
>}
There should be something like if (len == -EOPNOTSUPP) goto ret, where ret
should be right before return NULL. Or am I missing something? David, it's from
your tree, do you have any comments, ideas?

regards,
--
Jiri Slaby www.fi.muni.cz/~xslaby
\_.-^-._ jirislaby@gmail.com _.-^-._/
B67499670407CE62ACC8 22A032CC55C339D47A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-07 13:02    [W:0.277 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site