lkml.org 
[lkml]   [2005]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 7/8] Cleanup set_slab_attr()
Cleanup a loop in set_slab_attr().

mcd@arrakis:~/linux/source/linux-2.6.14+slab_cleanup/patches $ diffstat
set_slab_attr.patch
slab.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

-Matt
Change the
do { ... } while (--i);
loop in set_slab_attr to a
while (i--) { ... }
loop like the rest of the functions that do similar loops in mm/slab.c.

Index: linux-2.6.14+slab_cleanup/mm/slab.c
===================================================================
--- linux-2.6.14+slab_cleanup.orig/mm/slab.c 2005-11-07 16:00:09.005539608 -0800
+++ linux-2.6.14+slab_cleanup/mm/slab.c 2005-11-07 16:07:59.169063888 -0800
@@ -2141,11 +2141,11 @@ static void set_slab_attr(kmem_cache_t *

i = 1 << cachep->gfporder;
page = virt_to_page(objp);
- do {
+ while (i--) {
SET_PAGE_CACHE(page, cachep);
SET_PAGE_SLAB(page, slabp);
page++;
- } while (--i);
+ }
}

/*
\
 
 \ /
  Last update: 2005-11-08 02:00    [W:0.146 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site