lkml.org 
[lkml]   [2005]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kbuild updates
    On Mon, Nov 07, 2005 at 11:13:16AM +0100, Roman Zippel wrote:
    > Hi,
    >
    > On Sun, 6 Nov 2005, Sam Ravnborg wrote:
    >
    > > On Sun, Nov 06, 2005 at 01:44:32PM +0100, Roman Zippel wrote:
    > > >
    > > > What exactly is the problem? How does Fedora use QTLIB?
    > >
    > > See:
    > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=137926
    >
    > I'm not really happy with this patch. I don't really like relying on
    > QTLIB, it's a really ugly hack.

    I've forwarded your mail to Than Ngo (email was wrong in my origianl
    mail). As the original patch author I like him to comment/test.

    Sam

    > If the nonextisting ../lib64 dir is the problem, I'd more prefer a patch
    > like this:
    >
    > Index: linux-2.6/scripts/kconfig/Makefile
    > ===================================================================
    > --- linux-2.6.orig/scripts/kconfig/Makefile 2005-11-06 00:27:29.000000000 +0100
    > +++ linux-2.6/scripts/kconfig/Makefile 2005-11-07 11:08:58.000000000 +0100
    > @@ -162,9 +164,10 @@ $(obj)/.tmp_qtcheck:
    > echo "*"; \
    > false; \
    > fi; \
    > - LIBPATH=$$DIR/lib; LIB=qt; \
    > + LIBPATH=$$DIR/lib; LIB=qt; osdir=""; \
    > $(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \
    > - LIBPATH=$$DIR/lib/$$($(HOSTCXX) -print-multi-os-directory); \
    > + osdir=$$($(HOSTCXX) -print-multi-os-directory); \
    Common practice is to use $(shell $(HOSTCXX) -print-multi-os-directory)
    It's more obvious what you achive.

    Sam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-08 00:05    [W:0.023 / U:0.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site