lkml.org 
[lkml]   [2005]   [Nov]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 5 Nov 2005 21:21:33 -0800
FromPaul Jackson <>
SubjectDoes shmem_getpage==>shmem_alloc_page==>alloc_page_vma hold mmap_sem?
Andi,

The comment in mm/mempolicy.c for alloc_page_vma() states:

  Should be called with the mm_sem of the vma hold.

However it seems that the call chain (#ifdef CONFIG_NUMA):

  shmem_getpage ==> shmem_alloc_page ==> alloc_page_vma

where shmem_getpage() is called from many of the mm/shmem.c file
operations, is called without holding mmap_sem.  There is no
mention of mmap_sem in the entire mm/shmem.c file.

This doesn't seem right.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-06 06:25    [from the cache]
©2003-2008