Messages in this thread | | | Date | Fri, 4 Nov 2005 13:57:42 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] drivers/input/: possible cleanups |
| |
On Fri, Nov 04, 2005 at 01:42:07PM +0100, Vojtech Pavlik wrote: > On Fri, Nov 04, 2005 at 01:35:41PM +0100, Adrian Bunk wrote: > > This patch contains the following possible cleanups: > > - make needlessly glbal code static > > Agreed. > > > - gameport/gameport: #if 0 the unused global function gameport_reconnect > > That one should be an EXPORT_SYMBOL() API. If the export is missing, > then that's the bug that needs to be fixed. >...
There isn't even a header providing a function prototype which is quite strange for a part of an API.
> Vojtech Pavlik
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |