![]() | |||||||||||||
Messages in this thread Patch in this message |
On Thursday 03 November 2005 23:41, Al Viro wrote: > On Thu, Nov 03, 2005 at 11:19:02PM -0500, Dave Jones wrote: > > The missing '?' field is puzzling though. Looking at the diff, > > this should work. Is this a shortfalling of seq_file perhaps ? > > dmi_get_system_info() returns "" instead of "?" now, apparently... > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > Oops! I have that field in my BIOS so I never noticed the problem... I wonder if something like the patch below will fix it. -- Dmitry Signed-off-by: Dmitry Torokhov <dtor@mail.ru> --- drivers/char/i8k.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) Index: work/drivers/char/i8k.c =================================================================== --- work.orig/drivers/char/i8k.c +++ work/drivers/char/i8k.c @@ -99,7 +99,9 @@ struct smm_regs { static inline char *i8k_get_dmi_data(int field) { - return dmi_get_system_info(field) ? : "N/A"; + char *dmi_data = dmi_get_system_info(field); + + return dmi_data && *dmi_data ? dmi_data : "?"; } /* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-11-04 05:42 [from the cache] ©2003-2008 | |||||||||||||