lkml.org 
[lkml]   [2005]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Fwd: [PATCH] [PNP][RFC] Suspend support for PNP bus.]
    On 11/4/05, Pierre Ossman <drzeus-list@drzeus.cx> wrote:
    > +
    > +int pnp_start_dev(struct pnp_dev *dev)
    > +{
    > + if (!pnp_can_write(dev)) {
    > + pnp_info("Device %s does not supported activation.", dev->dev.bus_id);

    "...does not support...", there is no "ed" at the end.

    > + return -EINVAL;
    > + }

    Hmm, would'nt presence of such device stop suspend process? It will
    cause pnp_bus_resume to fail too. Perhaps returning 0 in this case is
    better.

    > +
    > +int pnp_stop_dev(struct pnp_dev *dev)
    > +{
    > + if (!pnp_can_disable(dev)) {
    > + pnp_info("Device %s does not supported disabling.", dev->dev.bus_id);
    > + return -EINVAL;

    Same here. No "ed" and -EINVAL will hurt.

    --
    Dmitry
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-04 15:51    [W:0.021 / U:30.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site