lkml.org 
[lkml]   [2005]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/37] dvb: dst: Correcty Identify Tuner and Daughterboards
Andrew Morton wrote:

>Michael Krufky <mkrufky@m1k.net> wrote:
>
>
>> +static int dst_get_tuner_info(struct dst_state *state)
>> +{
>> + u8 get_tuner_1[] = { 0x00, 0x13, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
>> + u8 get_tuner_2[] = { 0x00, 0x0b, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
>> +
>> + get_tuner_1[7] = dst_check_sum(get_tuner_1, 7);
>> + get_tuner_2[7] = dst_check_sum(get_tuner_2, 7);
>> + if (state->type_flags & DST_TYPE_HAS_MULTI_FE) {
>> + if (dst_command(state, get_tuner_2, 8) < 0) {
>> + dprintk(verbose, DST_INFO, 1, "Unsupported Command");
>> + return -1;
>> + }
>> + } else {
>> + if (dst_command(state, get_tuner_1, 8) < 0) {
>> + dprintk(verbose, DST_INFO, 1, "Unsupported Command");
>> + return -1;
>> + }
>> + }
>> + memset(&state->board_info, '\0', 8);
>> + memcpy(&state->board_info, &state->rxbuffer, 8);
>>
>>
>
>The memset is unneeded...
>
>
Hello Andrew,

I will have that changed in dvb-kernel CVS. Would you like me to send in
a patch for the same. Or you can have it changed .. ?


Thanks,
Manu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-03 10:41    [W:0.055 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site