lkml.org 
[lkml]   [2005]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] kconfig and lxdialog, kernel 2.6.13.4
Hi Roman,

Thank you for all of your feedback. It is much appreciated. Also, I
apologize for not getting back to you sooner; I got held up on a lot
of stuff at work.

On Thu, Oct 27, 2005 at 11:11:52PM +0200, Roman Zippel wrote:
>
> On Thu, 27 Oct 2005, Fao, Sean wrote:
>
> > http://www2.capitalgenomix.com/temp/linux_patch/format_patch
>
> Looks fine, but you could also please manually cleanup the parts which got
> too much indented to the right. Usually one tries to move them into
> separate functions, but sometimes exceeding the 80 char limit is IMO fine
> too.

Here is an updated patch for the updated 2.6.14 kernel. Please note,
however, that I have not done any cleanup because I wanted to know
your opinion, first. Would you rather I try to format my changes
the same as the *original* lxdialog style, or include the styling changes
in a separate patch and leave my formatting the way it is? I realize
that it's usually against common curtesy to modify the style, so I'll
take whatever advise you can give me on this.

http://www2.capitalgenomix.com/temp/linux_patch/format.patch

--
Sean

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-03 19:45    [W:0.175 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site