lkml.org 
[lkml]   [2005]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: First steps towards making NO_IRQ a generic concept

* Matthew Wilcox <matthew@wil.cx> wrote:

> [PATCH] Check the irq number is within bounds in the functions which
> weren't already checking.

> + if (irq >= NR_IRQS)
> + return;

hm, why not start with the -1 value for PCI_NO_IRQ, instead of 0:

> +#define PCI_NO_IRQ 0

and be done with it.

also:

> - Move the definition of NO_IRQ from asm directories to
> <linux/hardirq.h>. Individual architectures can still override it if
> they want to, but all existing definitions were -1.

we shouldnt make it overridable just for the sake of it. If all arches
were fine with -1, it should be the generic value and there's no
override.

plus, shouldnt this go into -mm first, since it clearly affects some
drivers? Why into Linus' tree immediately?

the patch series looks good to me otherwise.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-03 16:46    [W:0.078 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site