lkml.org 
[lkml]   [2005]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[git patch review 1/8] IPoIB: reinitialize path struct's completion for every query
    From
    Date
    It's possible that IPoIB will issue multiple SA queries for the same
    path struct. Therefore the struct's completion needs to be
    initialized for each query rather than only once when the struct is
    allocated, or else we might not wait long enough for later queries to
    finish and free the path struct too soon.

    Signed-off-by: Roland Dreier <rolandd@cisco.com>

    ---

    drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    applies-to: 9fd732ebc6b85090b64862c4ee3af7078ba1f822
    65c7eddaba33995e013ef3c04718f6dc8fdf2335
    diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
    index 2fa3075..cd58b3d 100644
    --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
    +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
    @@ -428,7 +428,6 @@ static struct ipoib_path *path_rec_creat
    skb_queue_head_init(&path->queue);

    INIT_LIST_HEAD(&path->neigh_list);
    - init_completion(&path->done);

    memcpy(path->pathrec.dgid.raw, gid->raw, sizeof (union ib_gid));
    path->pathrec.sgid = priv->local_gid;
    @@ -446,6 +445,8 @@ static int path_rec_start(struct net_dev
    ipoib_dbg(priv, "Start path record lookup for " IPOIB_GID_FMT "\n",
    IPOIB_GID_ARG(path->pathrec.dgid));

    + init_completion(&path->done);
    +
    path->query_id =
    ib_sa_path_rec_get(priv->ca, priv->port,
    &path->pathrec,
    ---
    0.99.9k
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-11-30 02:00    [W:0.020 / U:59.776 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site