lkml.org 
[lkml]   [2005]   [Nov]   [28]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    FromPierre Ossman <>
    Subject[PATCH] [MMC] Fix protocol errors
    DateMon, 28 Nov 2005 09:54:04 +0100
    A review against MMC/SD specifications found some errors in the current
    implementation.
    
    Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
    ---
     drivers/mmc/mmc.c            |    2 +-
     include/linux/mmc/protocol.h |    4 ++--
     2 files changed, 3 insertions(+), 3 deletions(-)
    diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
    index fa6835f..8c47100 100644
    --- a/drivers/mmc/mmc.c
    +++ b/drivers/mmc/mmc.c
    @@ -816,7 +816,7 @@ static void mmc_discover_cards(struct mm
     
     			cmd.opcode = SD_SEND_RELATIVE_ADDR;
     			cmd.arg = 0;
    -			cmd.flags = MMC_RSP_R1;
    +			cmd.flags = MMC_RSP_R6;
     
     			err = mmc_wait_for_cmd(host, &cmd, CMD_RETRIES);
     			if (err != MMC_ERR_NONE)
    diff --git a/include/linux/mmc/protocol.h b/include/linux/mmc/protocol.h
    index 06355fa..c359a8e 100644
    --- a/include/linux/mmc/protocol.h
    +++ b/include/linux/mmc/protocol.h
    @@ -63,7 +63,7 @@
       /* class 5 */
     #define MMC_ERASE_GROUP_START    35   /* ac   [31:0] data addr   R1  */
     #define MMC_ERASE_GROUP_END      36   /* ac   [31:0] data addr   R1  */
    -#define MMC_ERASE                37   /* ac                      R1b */
    +#define MMC_ERASE                38   /* ac                      R1b */
     
       /* class 9 */
     #define MMC_FAST_IO              39   /* ac   <Complex>          R4  */
    @@ -74,7 +74,7 @@
     
       /* class 8 */
     #define MMC_APP_CMD              55   /* ac   [31:16] RCA        R1  */
    -#define MMC_GEN_CMD              56   /* adtc [0] RD/WR          R1b */
    +#define MMC_GEN_CMD              56   /* adtc [0] RD/WR          R1  */
     
     /* SD commands                           type  argument     response */
       /* class 8 */
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2005-11-28 09:56    [from the cache]
    ©2003-2008