lkml.org 
[lkml]   [2005]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Reboot through the BIOS on newer HP laptops
Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>
> Newer HP laptops (nc4200, nc6xxx, nc8xxx) hang on reboot with a standard
> configuration. Passing reboot=b makes them work. This patch adds a DMI
> quirk that defaults them to this mode, and doesn't appear to have any
> adverse affects on older HPs.
>
> Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
>
> --- a/arch/i386/kernel/reboot.c.orig 2005-09-20 18:54:50.000000000 +0100
> +++ a/arch/i386/kernel/reboot.c 2005-09-20 18:58:11.000000000 +0100
> @@ -135,6 +135,14 @@
> DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge 2400"),
> },
> },
> + { /* HP laptops have weird reboot issues */
> + .callback = set_bios_reboot,
> + .ident = "HP Laptop",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
> + },
> + },
> { }
> };

This seems rather generic. I recently added one entry:

{ /* Handle problems with rebooting on HP nc6120 */
.callback = set_bios_reboot,
.ident = "HP Compaq nc6120",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq nc6120"),
},
},

But your patch will do this for all HP laptops, will it not? Worrisome.
Is it not possible to identify particular models?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-27 05:36    [W:0.052 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site