Messages in this thread | | | Date | Thu, 24 Nov 2005 06:06:26 +0100 | From | Adrian Bunk <> | Subject | Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static |
| |
On Wed, Nov 23, 2005 at 11:21:50PM -0500, Dave Jones wrote: > On Wed, Nov 23, 2005 at 11:54:40PM +0100, Adrian Bunk wrote: > > On Wed, Nov 23, 2005 at 02:46:51PM -0800, Randy.Dunlap wrote: > > > On Wed, 23 Nov 2005, Adrian Bunk wrote: > > > > > > > Every inline dummy function should be static. > > > > > > Please explain why it matters in this case. > > > > We don't need an additional global copy of the function. > > it's an empty body, surely the compiler will compile it away ?
For the one call in init/main.c the function is always inlined and optimized away.
But if it isn't static, gcc must additionally emit a global function.
> Dave
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |