lkml.org 
[lkml]   [2005]   [Nov]   [23]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [NET]: Shut up warnings in net/core/flow.c
FromArjan van de Ven <>
DateWed, 23 Nov 2005 10:11:24 +0100
On Wed, 2005-11-23 at 00:55 -0800, David S. Miller wrote:
> From: Andrew Morton <akpm@osdl.org>
> Date: Wed, 23 Nov 2005 00:21:34 -0800
> 
> > Nope, this will break !CONFIG_SMP builds.  Quite a few places in the
> > kernel do not implement the ipi handler if !CONFIG_SMP.
> 
> Ho hum, nothing is ever easy eh? :-) I think your patch is fine for
> now, but in the long term the !CONFIG_SMP ifdefs for those ipi
> handlers should probably just get removed.  If GCC can't optimize
> those things away, I'd be really surprised.

it can.. but only if we start using -ffunction-sections in the CFLAGS
(or make all of these functions static I suppose and reenable
-funit-at-a-time, which can be done for gcc 4.x only)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-23 09:14    [from the cache]
©2003-2008