lkml.org 
[lkml]   [2005]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND 2/2] - usbserial: race-condition fix.
    On Wed, Nov 23, 2005 at 03:46:50PM -0200, Luiz Fernando Capitulino wrote:
    > On Tue, 22 Nov 2005 14:13:53 -0800
    > Greg KH <gregkh@suse.de> wrote:
    >
    > | On Tue, Nov 22, 2005 at 07:59:26PM -0200, Luiz Fernando Capitulino wrote:
    > | > @@ -60,6 +61,7 @@ struct usb_serial_port {
    > | > struct usb_serial * serial;
    > | > struct tty_struct * tty;
    > | > spinlock_t lock;
    > | > + struct semaphore sem;
    > |
    > | You forgot to document what this semaphore is used for.
    >
    > Here goes the second patch again, with the documentation now.
    >
    > As I said before, would be good to apply these two patches now, and I
    > can cleanup the spinlock usage until next week.

    How will you clean it up?

    > Fixes a race-condition in the access of the port structure, described
    > in detail at: http://marc.theaimsgroup.com/?l=linux-kernel&m=113216151918308&w=2

    Please put the full detail in the email, so I can put it in the
    ChangeLog so people have an easy place to get the proper information.

    Care to redo it again?

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-23 19:04    [W:0.029 / U:59.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site