Messages in this thread |  | | | Subject | Re: Linux 2.6.15-rc2 | | From | Zan Lynx <> | | Date | Tue, 22 Nov 2005 22:01:37 -0700 | |
On Tue, 2005-11-22 at 17:39 -0800, Linus Torvalds wrote:
>
> On Tue, 22 Nov 2005, Andrew Morton wrote:
> > >
> > > Why does it happen at all, though?
> >
> > davem recently merged a patch which adds ext3 ioctls to fs/compat_ioctl.c.
> > That required inclusion of ext3 and jbd header files. Those files explode
> > unpleasantly when CONFIG_JBD=n.
>
> Oh. How about just making jbd.h do the rigt thing, and not care about the
> configuration?
>
> If we include jbd.h, we want the jbd data structures. There's never any
> reason to care whether jbd is enabled or not afaik.
>
> Ie maybe just something like this?
>
> (Untested, obviously. I'm just assuming that anything that actually
> _needs_ the jbd functionality should have made sure that jdb is enabled.)
>
> Zan, Jeffrey?
[snip patch]
Yes, that also works for me. It compiled and is running just fine.
--
Zan Lynx <zlynx@acm.org>
[unhandled content-type:application/pgp-signature] |  |